Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add security scanners for containers #652

Open
tomkralidis opened this issue Apr 18, 2024 · 9 comments
Open

add security scanners for containers #652

tomkralidis opened this issue Apr 18, 2024 · 9 comments
Assignees
Labels
security Security
Milestone

Comments

@tomkralidis
Copy link
Collaborator

Add trivy via GitHub Actions in order to scan containers for vulnerabilities.

@tomkralidis tomkralidis added the security Security label Apr 18, 2024
@tomkralidis tomkralidis added this to the sprint-015 milestone Apr 18, 2024
@tomkralidis tomkralidis self-assigned this Apr 18, 2024
@maaikelimper
Copy link
Collaborator

I ran trivy on the wis2box-api, it found one issue with severity=HIGH
https://github.com/wmo-im/wis2box-api/actions/runs/9615735356/job/26523621849

@maaikelimper
Copy link
Collaborator

question: should the GHA only fail on severity=CRITICAL ?

@tomkralidis
Copy link
Collaborator Author

  1. can we update wmo-im/dim_eccodes_baseimage to 22.04 ?
  2. we should be checking for severity: CRITICAL,HIGH

@maaikelimper
Copy link
Collaborator

maaikelimper commented Jun 24, 2024

Add trivy.yml to PR: #699

wis2box-management passes

wis2box-api, wis2box-ui and wis2box-webapp fail

image

@maaikelimper
Copy link
Collaborator

@tomkralidis how to proceed ?

  • Do I make new issues for each failed service in the wis2box-repo or in the original repo ?
  • Should I scan -all- containers (so also nginx, minio, prometheus etc.) or just those containers build out of wmo-im repositories ?

@tomkralidis
Copy link
Collaborator Author

  • add issues in this issue tracker regardless of the original repo, since we are running the GitHub Action here
  • only scan non-upstream

@maaikelimper
Copy link
Collaborator

after updating dim_eccodes_baseimage to use Ubuntu 22.04, wis2box-api now passes the vulnerability scan:
image

@tomkralidis
Copy link
Collaborator Author

2024-07-24:

@tomkralidis
Copy link
Collaborator Author

2024-08-14:

@tomkralidis tomkralidis modified the milestones: sprint-015, sprint-016 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security
Projects
None yet
Development

No branches or pull requests

2 participants