Hey @yuliya-ivaniukovich, I totally hear you!

Here's what I think:

There are a number of components depending on renderForms prop at the moment. Introducing a breaking change in this area would not be acceptable at the moment. What we can do though is introduce annotationMode prop which would give users greater control than renderForms flag.

We will need to do a better job at documenting things than Mozilla - annotationMode seems to be quite confusing if someone comes from renderForms approach.

PageCanvas needs an update in the line you've mentioned:

      annotationMode:
        annotationMode ?? (renderForms ? ANNOTATION_MODE.ENABLE_FORMS : ANNOTATION_MODE.ENABLE),

should do the trick!

Then, there's AnnotationLayer which actually uses renderForms flag:

      renderForms:
        annotationMode !== null && annotationMode !== undefined
          ? annotationMode === ANNOTATION_MODE.ENABLE_FORMS
          : renderForms,

?

Then, in Page, defaultProps would need to change: renderForms default flag value must be removed, and default value for annotationMode (ANNOTATION_MODE.ENABLE) should be set instead. childContext needs to be updated to pass annotationMode.

In Test & LayerOptions, annotationMode controls must be added.

What do you think?

So, the idea is that passing annotationMode={ANNOTATION_FORMS.ENABLE_FORMS} should work the same way as passing renderForms. The proposal sounds totally reasonable, thanks.

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

This issue was closed because it has been stalled for 14 days with no activity.