Closes #7104: Remove preload tag if host_fonts_locally is enabled

wp-media · Nov 13, 2024 · dcee3f0 · dcee3f0
1 parent 810538b
commit dcee3f0
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/inc/Engine/Optimization/GoogleFonts/AbstractGFOptimization.php b/inc/Engine/Optimization/GoogleFonts/AbstractGFOptimization.php
@@ -111,9 +111,19 @@ protected function get_font_display_value(): string {
 	 * @return string
 	 */
 	protected function get_optimized_markup( string $url ): string {
-		return sprintf(
-			'<link rel="preload" data-rocket-preload as="style" href="%1$s" /><link rel="stylesheet" href="%1$s" media="print" onload="this.media=\'all\'" /><noscript><link rel="stylesheet" href="%1$s" /></noscript>', // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedStylesheet
+		$markup = sprintf(
+			'<link rel="stylesheet" href="%1$s" media="print" onload="this.media=\'all\'" /><noscript><link rel="stylesheet" href="%1$s" /></noscript>', // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedStylesheet
 			$url
 		);
+
+		if ( ! get_rocket_option( 'host_fonts_locally', false ) ) {
+			$markup = sprintf(
+				'<link rel="preload" data-rocket-preload as="style" href="%1$s" />%2$s',
+				$url,
+				$markup
+			);
+		}
+
+		return $markup;
 	}
 }