Update DelayJS to v2

[MathieuLamiot]

DelayJS v2 must be released on WP Rocket.
The "v2" is currently available on the "v2" branch of the delay JS repo.

Here is the process to automatically update WP Rocket with a DelayJS release: https://www.notion.so/wpmedia/Maintaining-JavaScript-files-98e4112922d540da93e2536866e36fd8?pvs=4#95bb73a9447745228d1c6376e5ad3732

[wordpressfan]

I found this PR to merge v2 into develop then we can merge develop into main and release from main but I can see some conflicts, let me check if we can resolve the conflicts from our side or we will need to check with Gael.

[MathieuLamiot]

@wordpressfan This has already been discussed with Gael here: https://wp-media.slack.com/archives/CUT7FLHF1/p1729614432850799?thread_ts=1729184313.104719&cid=CUT7FLHF1

[wordpressfan]

Awesome, so we will ignore conflicts and keep the v2 changes.

[Mai-Saad]

Waiting feedback for possible regression https://wp-media.slack.com/archives/CUT7FLHF1/p1731051322877729?thread_ts=1729184313.104719&cid=CUT7FLHF1

[Mai-Saad]

Regression list

• clicking links on FF will load scripts before doing further interaction (using tab to open link is fine) https://wpmediaqa.testrail.io/index.php?/tests/view/44270&group_by=cases:section_id&group_id=4884&group_order=asc
• double tap needed for menu to open with certain template https://wp-media.slack.com/archives/CUT7FLHF1/p1731402244073589?thread_ts=1729184313.104719&cid=CUT7FLHF1
• clicking the link, we sometimes will see nothing is delayed on chrome/FF https://wp-media.slack.com/archives/CUT7FLHF1/p1731051322877729?thread_ts=1729184313.104719&cid=CUT7FLHF1

non-regression

• open page from saved tab loads all script without further interaction (even on 3.17.2.1 of wpr, so maybe browser changes is a factor)
  https://wpmediaqa.testrail.io/index.php?/tests/view/44269&group_by=cases:section_id&group_id=4884&group_order=asc
• this issue related to safari double click is still there Delay JS - Links needs to be clicked twice on iOS / Safari #3142

[piotrbak]

CC @gmetais

[gmetais]

Hi @Mai-Saad,

Could you please describe this issue a bit more?

open page from saved tab loads all script without further interaction (even on 3.17.2.1 of wpr, so maybe browser changes is a factor)
https://wpmediaqa.testrail.io/index.php?/tests/view/44269&group_by=cases:section_id&group_id=4884&group_order=asc

What is a saved tab? Is it related to the fact that DelayJS intentionally loads scripts when the page visibility is hidden?

[Mai-Saad]

@gmetais Here is a video about the saved tab (usually scripts aren't delayed there)
saved pages.zip