Closes #7104: Duplicated tag added to page #7105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miraeld
added
the
type: bug
remyperona
changed the base branch from
feature/host-google-fonts
to
feature/7063-google-font-front-end
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
jeawhanlee
approved these changes
Nov 14, 2024
Miraeld
changed the base branch from
feature/7063-google-font-front-end
to
feature/host-google-fonts
Khadreal
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needs to be merge after #7091
Fixes #7104
As of right now we are having 2 local css file tag in the html, with this PR we are fixing the issue by avoiding the
preloadtag to be added while combining google font. This way we endup with only 1 tag added to the html.Type of change
Detailed scenario
Please refer to issue.
Technical description
Documentation
We are adding a filter to avoid the preload tag to be added to the new feature. However, if needed we can still get the preload in the future.
New dependencies
None
Risks
None
Mandatory Checklist
Code validation
Code style