-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache pagination pages properly #7089
Conversation
… into fix/7088-cache-pagination-pages
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
@wp-media/engineering-plugin-team QA feedback to tackle: https://wp-media.slack.com/archives/CUT7FLHF1/p1730802316824809?thread_ts=1730733341.053669&cid=CUT7FLHF1 |
Description
Fixes #7088
Here we are fixing a regression from that PR: #6984
We now can cache pagination pages for terms (categories, tags, custom taxonomies like product_cat for woocommerce, ...etc.)
Type of change
Detailed scenario
To reproduce this issue, you need to visit a category page starting from the second page in pagination, before this PR, you will find it not cached.
Technical description
Documentation
We check if we are in a paged page so compare the urls with page query variable to match properly.
New dependencies
No
Risks
Do u know if we have any query variable like paged one or not?
Mandatory Checklist
Code validation
Code style
Additional Checks