-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #7065: 3.18 - Filter changing output #7107
Closes #7065: 3.18 - Filter changing output #7107
Conversation
4e7415b
to
8578b5f
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
cbe336f
to
764aa1d
Compare
Description
Fixes #7065
It allows the user to use the new added filter
rocket_internal_fonts_styling
in order to change the way we are including the local hosted fonts.If
rocket_host_fonts_locally_inline_css
returns true => We get the css within a<style></style>
tagif
rocket_host_fonts_locally_inline_css
returns false => We get the css within a<link rel="stylesheet" [...]>
tagType of change
Detailed scenario
Just set the filter mentioned in the description above to
true
and see the change on the front-end.Technical description
Documentation
Refer to the description, pretty simple.
New dependencies
Risks
Mandatory Checklist
Code validation
Code style