Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7065: 3.18 - Filter changing output #7107

Merged

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Nov 14, 2024

Description

Fixes #7065
It allows the user to use the new added filter rocket_internal_fonts_styling in order to change the way we are including the local hosted fonts.

If rocket_host_fonts_locally_inline_css returns true => We get the css within a <style></style> tag
if rocket_host_fonts_locally_inline_css returns false => We get the css within a <link rel="stylesheet" [...]> tag

Type of change

Detailed scenario

Just set the filter mentioned in the description above to true and see the change on the front-end.

Technical description

Documentation

Refer to the description, pretty simple.

New dependencies

Risks

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Nov 14, 2024
@Miraeld Miraeld requested a review from a team November 14, 2024 05:37
@Miraeld Miraeld self-assigned this Nov 14, 2024
@Miraeld Miraeld changed the title Closes #7065: Filter changing output Closes #7065: 3.18 - Filter changing output Nov 14, 2024
@MathieuLamiot MathieuLamiot linked an issue Nov 14, 2024 that may be closed by this pull request
Base automatically changed from fix/7104-duplicated-tag-added-to-page to feature/host-google-fonts November 14, 2024 07:57
@Miraeld Miraeld force-pushed the enhancement/7065-filter-changing-output branch from 4e7415b to 8578b5f Compare November 14, 2024 09:02
Copy link

codacy-production bot commented Nov 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3201ce51 88.89% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3201ce5) Report Missing Report Missing Report Missing
Head commit (ca172d6) 38358 16843 43.91%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7107) 18 16 88.89%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

inc/Engine/Media/Fonts/Frontend/Controller.php Outdated Show resolved Hide resolved
inc/Engine/Media/Fonts/Frontend/Controller.php Outdated Show resolved Hide resolved
inc/Engine/Media/Fonts/Frontend/Controller.php Outdated Show resolved Hide resolved
inc/Engine/Media/Fonts/Frontend/Controller.php Outdated Show resolved Hide resolved
@Miraeld Miraeld force-pushed the enhancement/7065-filter-changing-output branch from cbe336f to 764aa1d Compare November 15, 2024 04:52
@remyperona remyperona added this to the 3.18 milestone Nov 15, 2024
@Miraeld Miraeld requested review from remyperona and a team November 18, 2024 10:31
@Miraeld Miraeld merged commit 0793a79 into feature/host-google-fonts Nov 19, 2024
11 of 12 checks passed
@Miraeld Miraeld deleted the enhancement/7065-filter-changing-output branch November 19, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.18 - Filter to change the output method
3 participants