Make sure taxonomy non-latin base slugs are cached #7114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7106
This should fix the issue of having non-latin characters in base slugs for any taxonomy, the terms' pages for those taxonomies are not being cached.
Type of change
Detailed scenario
Category base
to beпродуктова-категория
then save permalinks.Technical description
Documentation
As I mentioned in the issue itself, there is a discussion in the core here:
https://core.trac.wordpress.org/ticket/16839
The main issue here is that When using
get_term_link
function, it puts the base slug without encoding it at all, but encoding the rest of the url (term slug) so when comparing the current page url with the term url, it fails, so here I decoded both urls before comparing them, and this works perfectly.New dependencies
No
Risks
I can't think of any risk here, this should work with encoded and non-encoded urls.
Mandatory Checklist
Code validation
Code style
Additional Checks