From 41fccb85ba541b66a51571d1fd8aea4029b9ec08 Mon Sep 17 00:00:00 2001 From: Bennett Perkins <1610227+bennettp123@users.noreply.github.com> Date: Thu, 27 Jul 2023 16:00:16 +0800 Subject: [PATCH 1/3] update node from 12.10.0 to 20.5.0 fixes https://github.com/wzieba/AppCenter-Github-Action/issues/54 --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 34fdae3..69bcbbb 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:12.10.0-alpine +FROM node:20.5.0-alpine WORKDIR /app COPY . /app From 188236edd8061bb36dbd6c54f1772a9bd753c450 Mon Sep 17 00:00:00 2001 From: Wojtek Zieba Date: Thu, 27 Jul 2023 10:29:44 +0200 Subject: [PATCH 2/3] Set as safe directory --- entrypoint.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/entrypoint.sh b/entrypoint.sh index 25775bb..74968c1 100644 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -1,4 +1,8 @@ #!/bin/bash -e + +# Required since https://github.blog/2022-04-12-git-security-vulnerability-announced +git config --global --add safe.directory $GITHUB_WORKSPACE + RELEASE_NOTES="" isFirst=true releaseId="" From a7817c71402af72190cf5466e4860cc1f322bf98 Mon Sep 17 00:00:00 2001 From: Wojtek Zieba Date: Thu, 27 Jul 2023 10:38:48 +0200 Subject: [PATCH 3/3] Remove 'pull_request_target' trigger event As this event triggers build against of the base of the pull request, the build triggered by it will fail when PR fixes already failing build of the base. --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d08a828..3433216 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,5 +1,5 @@ name: Sample workflow for App Center action -on: [push, pull_request, workflow_dispatch, pull_request_target] +on: [push, pull_request, workflow_dispatch] jobs: run: runs-on: ubuntu-latest