-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Invidious add-on when sharing YouTube URLs #978
Comments
wtimme
added a commit
to wtimme/Kore
that referenced
this issue
Oct 1, 2023
wtimme
added a commit
to wtimme/Kore
that referenced
this issue
Oct 1, 2023
This makes it easier to extend the functionality and incorporate other add-ons for YouTube.
wtimme
added a commit
to wtimme/Kore
that referenced
this issue
Oct 1, 2023
wtimme
added a commit
to wtimme/Kore
that referenced
this issue
Oct 1, 2023
Look at Tolriq/repository.yatse.kodi#41 how queuing is done - the plugin:// url is put into playlist which is queued. Also I encountered an issue with -1 as addon_handle and made a workaround PR referenced in the same link (but not merged yet :( ) |
SyncedSynapse
pushed a commit
that referenced
this issue
Nov 20, 2023
* Add setting for the preferred YouTube add-on (#978) * Move creation of YouTube plugin URL to a dedicated method (#978) This makes it easier to extend the functionality and incorporate other add-ons for YouTube. * Create a dedicated method for the default YouTube add-on (#978) * Add support for the Invidious add-on for YouTube (#978)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature suggestion
YouTube URLs shared with Kore should be playable with the Invidious add-on.
Detailed Description
Shared YouTube URLs currently require for the YouTube add-on (
plugin.video.youtube
) to be installed in Kodi. As outlined in #947, however, there are other plugins that support the playback of YouTube videos as well, such as the Invidious add-on.Context
The YouTube add-on
plugin.video.youtube
requires an API key. As a privacy-conscious user, I do not want to sign in to Google and link my viewing habits to an account. Rather, I want to watch YouTube anonymously - and Invidious is a great way to do so.Possible Implementation
Kore's settings could have a new
ListPreference
(e.g. titled "YouTube add-on") that allows users to select their preferred YouTube add-on. Internally, Kore could store the add-on's ID in the preferences.In
ShareOpenActivity.toPluginUrl()
, Kore would check which add-on is selected and, based on that, create theUri
specific to the add-on.I have already tried this with hard-coded values locally, and it seems to work as expected. Adding a
ListPreference
would allow us to extend this to other add-ons as well.One thing to note is that not every add-on supports queuing. The Invidious add-on, for example, does not. But for the MVP, I think it would be perfectly fine to only have the video played back.
Additional context, screenshots or links
Here are some relevant links or screenshots:
ShareOpenActivity.toPluginUrl()
Note: Team Kodi will consider this item however we will not make any promises if it will be included.
The text was updated successfully, but these errors were encountered: