Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

added password encrypt/decrypt stubs, recursive frame/iframe searches us... #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jguglielmi
Copy link

Added encrypt/decrypt stubs, recursive frame search capabilities (no more need for selectFrame) and contextMenu support.

@jguglielmi jguglielmi closed this May 4, 2014
@jguglielmi jguglielmi reopened this May 4, 2014
@jguglielmi jguglielmi mentioned this pull request May 6, 2014
@raboof
Copy link
Contributor

raboof commented Jun 28, 2015

A shame about all the whitespace changes - I added #147 to address that separately

@raboof
Copy link
Contributor

raboof commented Jun 28, 2015

Does searchAllFrames impact performance? It seems to make things a bit more complicated.

@raboof
Copy link
Contributor

raboof commented Jun 28, 2015

Where is encryptString actually used? Could we move this to a separate fixture?

@raboof
Copy link
Contributor

raboof commented Jun 28, 2015

It would be nice to have a example/test demonstrating the added features

@jguglielmi
Copy link
Author

It is a recursive call, but I hardly noticed anything.
On Jun 28, 2015 4:59 PM, "Arnout Engelen" notifications@github.com wrote:

Does searchAllFrames impact performance? It seems to make things a bit
more complicated.


Reply to this email directly or view it on GitHub
#122 (comment).

@jguglielmi
Copy link
Author

Sure. It is used within an OASIS REST call. There is also a decrypt as well.
On Jun 28, 2015 4:59 PM, "Arnout Engelen" notifications@github.com wrote:

Where is encryptString actually used? Could we move this to a separate
fixture?


Reply to this email directly or view it on GitHub
#122 (comment).

@@ -456,6 +524,81 @@ private boolean executeDoCommand(final String methodName, final String[] values)
}
}

private String encryptString(String password) { //encrypt exposed passwords or information stub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the encryption/decryption methods should move to their own fixture, outside of Xebium.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!
On Jun 28, 2015 5:50 PM, "Arnout Engelen" notifications@github.com wrote:

In src/main/java/com/xebia/incubator/xebium/SeleniumDriverFixture.java
#122 (comment):

@@ -456,6 +524,81 @@ private boolean executeDoCommand(final String methodName, final String[] values)
}
}

  • private String encryptString(String password) { //encrypt exposed passwords or information stub

I think the encryption/decryption methods should move to their own
fixture, outside of Xebium.


Reply to this email directly or view it on GitHub
https://github.com/xebia/Xebium/pull/122/files#r33427425.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants