-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package select different url will in different versions. #5962
Comments
不知道你要说啥,这不是原本就支持的么 |
I don’t know what you want to say. Isn’t this what I originally supported? |
我的意思是可以根据config来选择url,现在这个只是设置镜像,但是不能在config里选择。这个实现我随便填的,我觉得如果真的要实现可以下面这样 add_configs("oneapi", {description = "Use the OneAPI version on Linux", default = false, type = "boolean", urls="https://github.com/ispc/ispc/releases/download/v$(version)/ispc-v$(version)-linux-oneapi.tar.gz"}) 我对实现确实没有很多想法,主要就是缺一个根据config选择url的功能。 |
这个不太好支持,configs 初始化比较滞后,这个时候 url 已经没法再改了。 |
This is not easy to support. The initialization of configs is lagging behind. At this time, the url cannot be changed. |
可不可以在脚本里把某个已经添加的url给删除呢。我那个ispc的实现好像是可以正常安装的 |
Is it possible to delete a certain URL that has been added in the script? My implementation of ispc seems to be able to be installed normally. |
不太好弄,尽管你看上去没问题,那也仅仅只是一些特定包的表象,内部很多状态已经不一致了。遇到其他一些包,就可能会出各种问题。 前面对版本的选择,各种初始化,都已经读取早期的 urls 做了处理(比如决定是否走 git url 还是 tar url,版本选择都是不同的),后面突然改了 urls ,前面这些状态都会不一致。 |
It's not easy to do. Even if you seem to have no problem, it's just the appearance of some specific packages, and many internal states are already inconsistent. When encountering some other packages, various problems may occur. |
wouldn't it be possible to use on_download in that specific case? |
on_download can be used |
我现在这个感觉只要不是不同config的下载文件的sha256值就不会有问题应该 |
I now feel that as long as the sha256 value of the downloaded file is not different config, there should be no problem. |
但内部不可能只为了一个特定包没问题 去放开这种支持,而且里面还有很多其他处理了 |
But internally it is impossible to release this kind of support just for a specific package, and there are many other processes in it. |
Is your feature request related to a problem? Please describe.
boost
ispc
These two packages have shown that we need a url selector to select url in different package versions and different package configs.
In ispc, I use on_load script to implement this. It will first try to download the normal version. Yet it will fail and then try download from the oneapi config version.
For boost, there are two lines of comments mentioned the same problem.
Describe the solution you'd like
Maybe like this
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: