@SuperchupuDev could this be due to globby/minimatch replacement?

probably, there are some cases where optimizations can't be applied due to the glob patterns used, a workaround can be ignoring node_modules from globbing. sorry about that. there's some ongoing work in tinyglobby to greatly improve optimizations

@SuperchupuDev could you submit a PR with the suggested optimization please? Otherwise I would revert the glob replacement for now as the time is 5x and is too high

should be a one line fix with the ignore option, can do, but first i must ask, is the collect function ever supposed to return files from node_modules? if yes i'll have to fix the problem at its core (finishing the better optimizations in tinyglobby), which shouldn't take long as most of the work is done

@SuperchupuDev Yeah that could return files from node_modules

ah, then i'll try to finish the optimizations and publish a new tinyglobby version. meanwhile, can you try to give me a list of glob patterns commonly used by pkg? just to make sure

@SuperchupuDev Glob patterns used there can be provided by users, them are fetched from scripts and assets provided in pkg configuration in package.json

interesting. what's the pattern used in the repro provided in this issue? is it the same one that's actually passed to tinyglobby or is it transformed in some way beforehand?

I have no clue, I think you can try with the provided zip in the issue above?

I also have a feel that the reason caused issue listed in #112 test-80-compression-node-opcua, maybe you can give a try with that? Actually that test takes forever and uses pnpm and has assets. See development.md to understand how to spin tests locally

small update: SuperchupuDev/tinyglobby#69 is in theory done, but it breaks vite's tests. will investigate more tomorrow, and merge once i can make sure it doesn't cause any regressions

debugging the repro zip file made me see the issue with the glob usage done in this package: it is calling globSync many times, when once should be enough. improving this should solve this issue without needing to wait for tinyglobby

i've opened #121 which should solve this issue, but the usage of globSync is still not optimal here until this project stops calling globSync more than once, regardless of the glob library used