[Not for merging] Issue #166 Fix src/library/blockcodecs tests #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #166
TBlockCodecsTest::TestListAllCodecs
, где проверялось наличие всех кодеков, но поскольку zstd06 больше нигде не нужна, я решил, что лучше отключить тест, чем тащить её обратно.TestAllAtOnce
при вызове методаAsString
у пустогоTBuffer
. У libstdc++ слишком консервативныйstd::string::assign(const char*, size_t)
не принимает нулевые указатели в отличие от libc++. Предложил исправление. Upd: хотя, раз эта проблема появляется уже второй раз, возможно, лучше добавить проверку на нулевой указатель вTBasicString::assign
и в тех местах в классе, где вызываетсяstd::basic_string::assign
?