Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: get rid of old nodes tables #1678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: get rid of old nodes tables #1678

wants to merge 1 commit into from
+245 −388

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Nov 22, 2024 •
edited by github-actions bot
Loading

Closes #1642

Stand

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
194 194 0 0 0

Bundle Size: 🔽

Current: 66.09 MB | Main: 66.10 MB
Diff: 0.01 MB (-0.02%)

✅ Bundle size decreased.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copilot
Copilot AI reviewed Nov 22, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • src/containers/Nodes/NodesWrapper.tsx: Evaluated as low risk
  • src/containers/Nodes/PaginatedNodes.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

src/containers/Nodes/NodesTable.tsx:17

  • The interface name NodesTableProps is clear and consistent with the new naming convention.
interface NodesTableProps {
@astandrik astandrik force-pushed the astandrik.get-rid-of-old-nodes-tables-1642 branch from 10e74ed to 85d32e0 Compare November 22, 2024 23:13
@astandrik astandrik force-pushed the astandrik.get-rid-of-old-nodes-tables-1642 branch from 85d32e0 to 62dc1a5 Compare November 22, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@Raubzeug Raubzeug Awaiting requested review from Raubzeug

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of old nodes tables
1 participant
@astandrik