Skip to content

Commit

Permalink
Merge pull request #1259 from ydb-platform/driver-query
Browse files Browse the repository at this point in the history
* Excluded `Query()` method from interface `ydb.Connection`. Method `Query()` remains accessible from `ydb.Driver`
  • Loading branch information
asmyasnikov authored Jun 6, 2024
2 parents 45d084d + 33126c7 commit fa56b8c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Excluded `Query()` method from interface `ydb.Connection`. Method `Query()` remains accessible from `ydb.Driver`

## v3.71.0
* Added `query/ResultSet.{Columns,ColumnTypes}` methods for get column names and types from query result set
* Added experimental `retry.RetryWithResult` helper for retry lambda and return value from lambda
Expand Down
6 changes: 0 additions & 6 deletions connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (

"github.com/ydb-platform/ydb-go-sdk/v3/coordination"
"github.com/ydb-platform/ydb-go-sdk/v3/discovery"
"github.com/ydb-platform/ydb-go-sdk/v3/query"
"github.com/ydb-platform/ydb-go-sdk/v3/ratelimiter"
"github.com/ydb-platform/ydb-go-sdk/v3/scheme"
"github.com/ydb-platform/ydb-go-sdk/v3/scripting"
Expand Down Expand Up @@ -35,11 +34,6 @@ type Connection interface { //nolint:interfacebloat
// Table returns table client
Table() table.Client

// Query returns query client
//
// Experimental: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#experimental
Query() query.Client

// Scheme returns scheme client
Scheme() scheme.Client

Expand Down
3 changes: 1 addition & 2 deletions driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import (
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsync"
"github.com/ydb-platform/ydb-go-sdk/v3/log"
"github.com/ydb-platform/ydb-go-sdk/v3/query"
"github.com/ydb-platform/ydb-go-sdk/v3/ratelimiter"
"github.com/ydb-platform/ydb-go-sdk/v3/scheme"
"github.com/ydb-platform/ydb-go-sdk/v3/scripting"
Expand Down Expand Up @@ -192,7 +191,7 @@ func (d *Driver) Table() table.Client {
// Query returns query client
//
// Experimental: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#experimental
func (d *Driver) Query() query.Client {
func (d *Driver) Query() *internalQuery.Client {
return d.query.Get()
}

Expand Down

0 comments on commit fa56b8c

Please sign in to comment.