Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added table.Session.ReadRows #794

Merged
merged 2 commits into from
Aug 1, 2023
Merged

* Added table.Session.ReadRows #794

merged 2 commits into from
Aug 1, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Jul 30, 2023
@asmyasnikov asmyasnikov added the enhancement New feature or request label Jul 30, 2023
@github-actions
Copy link

github-actions bot commented Jul 30, 2023

github.com/ydb-platform/ydb-go-sdk/v3/table

incompatible changes

Session.ReadRows: added

github.com/ydb-platform/ydb-go-sdk/v3/table/options

compatible changes

ChangefeedFormatDynamoDBStreamsJSON: added
ReadRowsDesc: added
ReadRowsOption: added
readColumnsOption.ApplyReadRowsOption: added

summary

Base version: v3.49.0-rc0.0.20230801005458-b2dd07037119 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.49.0-rc0.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16% ⚠️

Comparison is base (b2dd070) 66.37% compared to head (67da62a) 66.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   66.37%   66.22%   -0.16%     
==========================================
  Files         233      233              
  Lines       23030    23065      +35     
==========================================
- Hits        15287    15275      -12     
- Misses       6944     6989      +45     
- Partials      799      801       +2     
Flag Coverage Δ
53.68% <0.00%> (-0.06%) ⬇️
go-1.17.x 66.09% <0.00%> (+0.07%) ⬆️
go-1.19.x 66.01% <0.00%> (-0.14%) ⬇️
go-1.20.x 65.99% <0.00%> (-0.30%) ⬇️
integration 53.68% <0.00%> (-0.06%) ⬇️
macOS 41.15% <0.00%> (-0.08%) ⬇️
ubuntu 41.15% <0.00%> (-0.12%) ⬇️
unit 41.15% <0.00%> (-0.18%) ⬇️
windows ?
ydb-22.5 53.37% <0.00%> (+0.04%) ⬆️
ydb-23.1 53.31% <0.00%> (-0.12%) ⬇️
ydb-23.2 53.37% <0.00%> (+0.02%) ⬆️
ydb-23.2-slim 53.39% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/table/session.go 80.90% <0.00%> (-3.16%) ⬇️
table/options/options.go 56.21% <0.00%> (-0.22%) ⬇️
table/table.go 77.00% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@asmyasnikov asmyasnikov force-pushed the read-rows branch 3 times, most recently from 01d3680 to 47e0630 Compare August 1, 2023 07:17
@asmyasnikov asmyasnikov merged commit 10d41a8 into master Aug 1, 2023
30 of 32 checks passed
@asmyasnikov asmyasnikov deleted the read-rows branch August 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants