added check if commit order is bad in sync mode #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingersamurai
added
enhancement
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 66.29% 66.52% +0.22%
==========================================
Files 233 233
Lines 23065 23079 +14
==========================================
+ Hits 15292 15353 +61
+ Misses 6976 6933 -43
+ Partials 797 793 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gingersamurai
force-pushed
the
feature/Return_error_if_commit_order_is_bad_for_sync_commit_mode
branch
from
567432a
to
ba719e6
Compare
rekby
reviewed
Aug 4, 2023
| @@ -108,6 +108,66 @@ func TestTopicStreamReaderImpl_CommitStolen(t *testing.T) { | |||
| xtest.WaitChannelClosed(t, commitReceived) | |||
| xtest.WaitChannelClosed(t, readRequestReceived) | |||
| }) | |||
| xtest.TestManyTimesWithName(t, "wrong order commit with sync commit mode", func(t testing.TB) { | |||
There was a problem hiding this comment.
Make name without space please - it will allow to find test be Ctrl+F. Now it will difficult, because space will replace with underscore (_) in test name.
…d_for_sync_commit_mode
rekby
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
Issue Number: #783