Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Changed period for re-fresh static credentials token from 1/2 to … #865

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

asmyasnikov
Copy link
Member

1/10 to expiration time

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb20e38) 39.51% compared to head (5bcb7f5) 66.09%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #865       +/-   ##
===========================================
+ Coverage   39.51%   66.09%   +26.58%     
===========================================
  Files         199      253       +54     
  Lines       20358    23892     +3534     
===========================================
+ Hits         8044    15791     +7747     
+ Misses      11963     7264     -4699     
- Partials      351      837      +486     
Flag Coverage Δ
52.91% <100.00%> (?)
go-1.17.x 64.63% <100.00%> (+25.37%) ⬆️
go-1.20.x 65.92% <100.00%> (+26.41%) ⬆️
go-1.21.x 65.92% <100.00%> (+26.39%) ⬆️
integration 52.91% <100.00%> (?)
macOS 39.48% <0.00%> (-0.01%) ⬇️
ubuntu 39.51% <0.00%> (+0.02%) ⬆️
unit 39.59% <0.00%> (+0.07%) ⬆️
windows 39.51% <0.00%> (?)
ydb-22.5 52.56% <100.00%> (?)
ydb-23.1 52.59% <100.00%> (?)
ydb-23.2 52.56% <100.00%> (?)
ydb-23.3 52.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/credentials/static.go 67.02% <100.00%> (+36.17%) ⬆️

... and 188 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

summary

Base version: v3.53.4 (master)
Suggested version: v3.53.5

@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

@asmyasnikov asmyasnikov merged commit f56f07b into master Oct 22, 2023
48 of 49 checks passed
@asmyasnikov asmyasnikov deleted the refresh-interval branch October 22, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants