Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added ydb.WithTraceRetry option #868

Merged
merged 1 commit into from
Oct 23, 2023
Merged

* Added ydb.WithTraceRetry option #868

merged 1 commit into from
Oct 23, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the enhancement New feature or request label Oct 22, 2023
@asmyasnikov asmyasnikov self-assigned this Oct 22, 2023
@github-actions
Copy link

github-actions bot commented Oct 22, 2023

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

WithTraceRetry: added

github.com/ydb-platform/ydb-go-sdk/v3/config

compatible changes

WithTraceRetry: added
github.com/ydb-platform/ydb-go-sdk/v3/internal/config.(*Common).TraceRetry: added

github.com/ydb-platform/ydb-go-sdk/v3/metrics

incompatible changes

Retry: removed

github.com/ydb-platform/ydb-go-sdk/v3/retry

incompatible changes

WithTrace: changed from func(github.com/ydb-platform/ydb-go-sdk/v3/trace.Retry) traceOption to func(*github.com/ydb-platform/ydb-go-sdk/v3/trace.Retry) traceOption

summary

Base version: v3.53.5-0.20231023210957-e1a1bb576efd (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.53.4.

@asmyasnikov asmyasnikov force-pushed the with-trace-retry branch 2 times, most recently from ba61306 to e5bbc17 Compare October 22, 2023 18:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (15ba102) 66.24% compared to head (25dc930) 66.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   66.24%   66.78%   +0.53%     
==========================================
  Files         255      255              
  Lines       24041    24138      +97     
==========================================
+ Hits        15926    16120     +194     
+ Misses       7273     7182      -91     
+ Partials      842      836       -6     
Flag Coverage Δ
53.33% <81.13%> (+0.48%) ⬆️
go-1.17.x 65.45% <80.18%> (+0.67%) ⬆️
go-1.20.x 66.54% <81.60%> (+0.31%) ⬆️
go-1.21.x 66.60% <81.60%> (+0.38%) ⬆️
integration 53.33% <81.13%> (+0.48%) ⬆️
macOS 39.40% <12.00%> (-0.02%) ⬇️
ubuntu 39.34% <12.00%> (-0.10%) ⬇️
unit 39.47% <12.00%> (-0.02%) ⬇️
windows 39.35% <12.00%> (-0.09%) ⬇️
ydb-22.5 53.12% <81.13%> (+0.49%) ⬆️
ydb-23.1 52.96% <81.13%> (+0.38%) ⬆️
ydb-23.2 52.94% <81.13%> (+0.28%) ⬆️
ydb-23.3 53.10% <81.13%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
config/config.go 79.71% <100.00%> (+0.60%) ⬆️
connection.go 81.72% <100.00%> (+0.06%) ⬆️
internal/config/config.go 90.00% <100.00%> (+2.50%) ⬆️
internal/scripting/client.go 72.68% <100.00%> (+1.48%) ⬆️
internal/table/client.go 87.47% <100.00%> (+1.60%) ⬆️
internal/table/retry.go 79.48% <100.00%> (-0.68%) ⬇️
internal/topic/topicclientinternal/client.go 86.92% <100.00%> (+1.11%) ⬆️
internal/xsql/connector.go 59.31% <100.00%> (+2.06%) ⬆️
metrics/retry.go 100.00% <100.00%> (+100.00%) ⬆️
metrics/traces.go 81.25% <100.00%> (+1.25%) ⬆️
... and 8 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

@asmyasnikov asmyasnikov force-pushed the with-trace-retry branch 11 times, most recently from 0d0fe04 to 61ec6cc Compare October 23, 2023 21:49
@asmyasnikov asmyasnikov merged commit 43bf888 into master Oct 23, 2023
48 of 49 checks passed
@asmyasnikov asmyasnikov deleted the with-trace-retry branch October 23, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants