KIKIMR-19704: add validation for prevent repeateble execution task

ydb-platform · Oct 14, 2023 · 3a0ef9c · 3a0ef9c
1 parent 500a0e1
commit 3a0ef9c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/ydb/core/tx/conveyor/usage/abstract.cpp b/ydb/core/tx/conveyor/usage/abstract.cpp
@@ -1,10 +1,13 @@
 #include "abstract.h"
 #include <library/cpp/actors/core/monotonic.h>
+#include <library/cpp/actors/core/log.h>
 #include <util/generic/yexception.h>
 #include <util/string/builder.h>
 
 namespace NKikimr::NConveyor {
 bool ITask::Execute(std::shared_ptr<TTaskSignals> signals) {
+    AFL_VERIFY(!ExecutedFlag);
+    ExecutedFlag = true;
     bool result = false;
     const TMonotonic start = TMonotonic::Now();
     try {

diff --git a/ydb/core/tx/conveyor/usage/abstract.h b/ydb/core/tx/conveyor/usage/abstract.h
@@ -40,6 +40,7 @@ class ITask {
     YDB_READONLY_DEF(TString, ErrorMessage);
     YDB_ACCESSOR(EPriority, Priority, EPriority::Normal);
     YDB_READONLY_DEF(std::optional<NActors::TActorId>, OwnerId);
+    bool ExecutedFlag = false;
 protected:
     ITask& SetErrorMessage(const TString& message) {
         ErrorMessage = message;