Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common application parameters to separate file #277

Open
vjik opened this issue Feb 5, 2023 · 4 comments
Open

Extract common application parameters to separate file #277

vjik opened this issue Feb 5, 2023 · 4 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@vjik
Copy link
Member

vjik commented Feb 5, 2023

Extract this:

[
    'charset' => 'UTF-8',
    'locale' => 'en',
    'name' => 'My Project',
]

to application-params.php.

@samdark
Copy link
Member

samdark commented Feb 5, 2023

I don't think it is needed. These look alright in params.php.

@vjik
Copy link
Member Author

vjik commented Feb 5, 2023

params.php - basicaly a place for service configuration. Application params configure ApplicationParameter class, that use directly for get params. Perhaps will be more convenient use separate application-params.php for it.

@terabytesoftw
Copy link
Member

All right, i’ve used it and it’s great to have them separated, actually rename params.php, to config-params.php

@samdark
Copy link
Member

samdark commented Feb 6, 2023

Alright. Let's apply it then.

@samdark samdark added status:ready for adoption Feel free to implement this issue. and removed status:under discussion labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

No branches or pull requests

3 participants