You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Just as memo that might either help to fix Kairos or to remove unused code.
User story
As a developer of KairosDB fork I want to remove all functionality related to storing tag names and tag values in Cassandra table string_index So that there is no dangling and unused functionality and no more unnecessary requests to Cassandra in putDataPoint method
Explanation
Current fork of KairosDB supports storing tag names and tag values in Cassandra table string_index . It keeps them in keys tag_names and tag_values. However, those values are never read. Because actual tags and values are fetched by selecting latest 9999 data row keys for a specific metric. Start looking from org.kairosdb.core.http.rest.MetricsResource#getMeta which serves "/datapoints/query/tags" endpoint. Eventually you'll reach org.kairosdb.datastore.cassandra.CassandraDatastore#queryMetricTags:
It works so, because every data row key contains associated tags.
Thus, tag_names and tag_values keys in string_index table and all related functionality is, in fact, not needed and we can safely get rid of it.
However, metric_names key in string_index table is still in use. Thus, just dropping whole string_index table is not an option.
This change is specific for ZMON and drags the fork further from original KairosDB.
The text was updated successfully, but these errors were encountered:
Just as memo that might either help to fix Kairos or to remove unused code.
User story
As a developer of KairosDB fork
I want to remove all functionality related to storing tag names and tag values in Cassandra table
string_index
So that there is no dangling and unused functionality and no more unnecessary requests to Cassandra in
putDataPoint
methodExplanation
Current fork of KairosDB supports storing tag names and tag values in Cassandra table
string_index
. It keeps them in keystag_names
andtag_values
. However, those values are never read. Because actual tags and values are fetched by selecting latest 9999 data row keys for a specific metric. Start looking fromorg.kairosdb.core.http.rest.MetricsResource#getMeta
which serves"/datapoints/query/tags"
endpoint. Eventually you'll reachorg.kairosdb.datastore.cassandra.CassandraDatastore#queryMetricTags
:It works so, because every data row key contains associated tags.
Thus,
tag_names
andtag_values
keys instring_index
table and all related functionality is, in fact, not needed and we can safely get rid of it.However,
metric_names
key instring_index
table is still in use. Thus, just dropping wholestring_index
table is not an option.This change is specific for ZMON and drags the fork further from original KairosDB.
The text was updated successfully, but these errors were encountered: