Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

It is time to move to Python3 #399

Closed
wants to merge 39 commits into from
Closed

It is time to move to Python3 #399

wants to merge 39 commits into from

Conversation

mohabusama
Copy link
Contributor

It is time to move to Python3

Resolve #7

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #399 into master will increase coverage by 0.55%.
The diff coverage is 77.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   75.31%   75.87%   +0.55%     
==========================================
  Files          80       80              
  Lines        5952     5944       -8     
==========================================
+ Hits         4483     4510      +27     
+ Misses       1469     1434      -35
Impacted Files Coverage Δ
zmon_worker_monitor/web_server/rest_api/errors.py 57.14% <0%> (ø) ⬆️
zmon_worker_monitor/web_server/rest_api/commons.py 50% <0%> (ø) ⬆️
zmon_worker_monitor/web_server/rest_api/api_v2.py 45.07% <0%> (ø) ⬆️
...worker_monitor/adapters/ifunctionfactory_plugin.py 95% <100%> (-0.24%) ⬇️
..._worker_monitor/zmon_worker/notifications/hubot.py 33.33% <100%> (ø) ⬆️
...orker_monitor/zmon_worker/notifications/hipchat.py 25.53% <100%> (ø) ⬆️
zmon_worker_monitor/builtins/plugins/kairosdb.py 96.82% <100%> (+0.05%) ⬆️
.../zmon_worker/notifications/google_hangouts_chat.py 90.47% <100%> (ø) ⬆️
zmon_worker_monitor/builtins/plugins/mongodb.py 60.71% <100%> (ø) ⬆️
zmon_worker_monitor/rpc_server.py 86.95% <100%> (ø) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb08ef9...09659f2. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #399 into master will increase coverage by 0.45%.
The diff coverage is 73.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   75.56%   76.02%   +0.45%     
==========================================
  Files          80       80              
  Lines        5918     5885      -33     
==========================================
+ Hits         4472     4474       +2     
+ Misses       1446     1411      -35
Impacted Files Coverage Δ
zmon_worker_monitor/web_server/rest_api/errors.py 57.14% <0%> (ø) ⬆️
zmon_worker_monitor/web_server/rest_api/commons.py 50% <0%> (ø) ⬆️
...er_monitor/builtins/plugins/distance_to_history.py 15.29% <0%> (ø) ⬆️
zmon_worker_monitor/web_server/rest_api/api_v2.py 45.07% <0%> (ø) ⬆️
...worker_monitor/adapters/ifunctionfactory_plugin.py 95% <100%> (-0.24%) ⬇️
zmon_worker_monitor/builtins/plugins/kairosdb.py 96.77% <100%> (ø) ⬆️
.../zmon_worker/notifications/google_hangouts_chat.py 90.47% <100%> (ø) ⬆️
zmon_worker_monitor/builtins/plugins/mongodb.py 60.71% <100%> (ø) ⬆️
zmon_worker_monitor/rpc_server.py 86.95% <100%> (ø) ⬆️
zmon_worker_monitor/adapters/ibase_plugin.py 80% <100%> (-1.82%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35fae32...3f95514. Read the comment docs.

@mohabusama mohabusama marked this pull request as ready for review April 9, 2019 20:52
@mohabusama mohabusama requested a review from vetinari April 9, 2019 20:56
@pitr pitr closed this Mar 22, 2020
@pitr pitr deleted the 2to3 branch March 22, 2020 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support/migrate to Python 3
3 participants