Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GPG signing to be skipped in development #16

Open
sbesson opened this issue Sep 25, 2023 · 1 comment
Open

Allow GPG signing to be skipped in development #16

sbesson opened this issue Sep 25, 2023 · 1 comment

Comments

@sbesson
Copy link

sbesson commented Sep 25, 2023

jzarr/pom.xml

Lines 246 to 262 in d4f85aa

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>1.6</version>
<executions>
<execution>
<id>sign-artifacts</id>
<phase>verify</phase>
<goals>
<goal>sign</goal>
</goals>
<configuration>
<keyname>9F88D86AD9A0D91E</keyname>
</configuration>
</execution>
</executions>
</plugin>
was introduced as part of 00180d1 as a prerequisite to the deployment to OSS Sonatype - see https://central.sonatype.org/publish/requirements/#sign-files-with-gpgpgp.

While this works very elegantly in the context of artifact publication via GitHub Actions, this breaks local developer workflow while running mvn install. Supporting both workflows might require defining a profile to allow the artifact signing to be triggered conditionally.

@joshmoore
Copy link
Member

In the way of info, 9F88D86AD9A0D91E from https://github.com/zarr-developers/jzarr/blob/main/pom.xml#L258C34-L258C50 is a dedicated GPG key:

pub   rsa2048 2023-05-19 [SC]
      E8CF B87E 58C0 2B91 1AB5  37BC 9F88 D86A D9A0 D91E
uid           [ultimate] Zarr Developers (Automated GitHub Signing) <zarrdevelopers@gmail.com>
sub   rsa2048 2023-05-19 [E]

that's been registered with GitHub and Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants