Use implicit fill values for zarr v2 #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Oct 7, 2024
rabernat
reviewed
Oct 8, 2024
rabernat
approved these changes
Oct 8, 2024
jhamman
reviewed
Oct 9, 2024
| out[out_selection] = chunk_spec.fill_value | ||
| fill_value = chunk_spec.fill_value | ||
|
|
||
| if fill_value is None: |
There was a problem hiding this comment.
Something we may consider in the future is to parameterize the CodecPipeline class with the zarr_format of the calling Array. This would allow us feel more confident that workarounds like this one only apply to v2 data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2271
I'm not sure if this is a good idea, but this, consolidated metadata, and #2270 lets xarray round trip a dataset. The basic idea is to let
ArrayV2Metadatarepresent the v2 metadata a bit more faithfully. Currently, we "eagerly" interpret the lack offill_valuein a V2 document as the default fill value for some dtype (e.g.0for int64). This PR changes that, to allowArrayV2Metadata.fill_valueto be None if it's unspecified in the metadata. But we do need some fill value when reading data. So that's where we finally substitute in the default.This doesn't really affect Zarr directly, but it is useful for downstream libraries that want to inspect the array metadata before reading and make some decision based on whether or not
fill_valueis specified.TODO: