Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELI15: in example load_constant() and load_private() seem to overwrite the same column #825

Open
ThrasherLT opened this issue Aug 5, 2024 · 0 comments

Comments

@ThrasherLT
Copy link

Which section of the Halo 2 book were you reading?

A simple example
https://zcash.github.io/halo2/user/simple-example.html

What was unclear?

load_private() and load_constant() both write to the same advice column config.advice[0], 0, without any explanation. Is this deliberate and it doesn't matter that the values are being overwritten or is this a bug and values are being overwritten? I've tried to change it to write to config.advice[1] for variable b, but that didn't change the results of the proof, so it seems like it doesn't matter?

What would help to make it clearer to you?

Fix, if this is a bug, or add a comment clarifying that this is deliberate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant