Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change certain APIs to be async #213

Open
4 tasks
junosuarez opened this issue Feb 5, 2016 · 0 comments
Open
4 tasks

Change certain APIs to be async #213

junosuarez opened this issue Feb 5, 2016 · 0 comments
Labels
enhancement
Milestone
1.0.0

Comments

@junosuarez
Copy link
Contributor

This is a tracking issue.
Right now we have some synchronous methods which do quite a bit of iteration (sometimes on multiple levels of references) synchronously, which is silly and unsafe.

  • PresenceManager#getOnline
  • PresenceManager#getClientsOnline
  • While we're at it, address the #fixme on PresenceManager#addClient (use options object for named params)

Some places could be cleaned up with Promises:

  • PresenceManager#fullRead
@junosuarez junosuarez added this to the 1.0.0 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@junosuarez