Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XA COMMIT ONE PHASE self-blocks at rotation #6

Open
jd-zhang opened this issue Aug 19, 2021 · 2 comments
Open

XA COMMIT ONE PHASE self-blocks at rotation #6

jd-zhang opened this issue Aug 19, 2021 · 2 comments
Assignees
@david-zhao
Labels
#critical defect @high kunlun-storage

Comments

@jd-zhang
Copy link
Contributor

Issue migrated from trac ticket # 140

component: kunlun-storage | priority: major | keywords: binlog;XA COMMIT ONE PHASE;rotation

2021-08-19 09:51:12: @david-zhao created the issue

This issue only exists in open source version of kunlun-storage.

If binlog rotation is initiated by a XA COMMIT ONE PHASE transaction commit, the worker thread blocks itself.

This is caused by two fixes which make sure XA COMMIT ONE PHASE txns are crash safe. Such fixes are correct but not sufficient --- we have to avoid doing rotation at XA COMMIT ONE PHASE commits.
@jd-zhang
Copy link
Contributor Author

2021-08-19 16:28:00: @david-zhao commented

fixed and committed at revision 00f1eba of github repo: https://github.com/zettadb/kunlun-storage

@jd-zhang
Copy link
Contributor Author

2021-08-19 16:28:00: @david-zhao changed status from assigned to accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-zhao david-zhao

Labels
#critical defect @high kunlun-storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@david-zhao @jd-zhang