Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Node.js Buffer wrapper #70

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Refactor Node.js Buffer wrapper #70

merged 2 commits into from
Jun 15, 2024

Conversation

05nelsonm
Copy link
Owner

Closes #66

Does a few minor things here

  1. Adds Buffer.alloc static function
  2. Adds Buffer.MAX_LENGTH variable
  3. Buffer.length no returns Number instead of Long
  4. Throwable.errorCodeOrNull is now public

@05nelsonm 05nelsonm self-assigned this Jun 15, 2024
05nelsonm
05nelsonm commented Jun 15, 2024
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@05nelsonm 05nelsonm merged commit 954ec30 into master Jun 15, 2024
6 checks passed
@05nelsonm 05nelsonm deleted the issue/66-js-buffer branch June 15, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@05nelsonm 05nelsonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Buffer.alloc for Node.js
1 participant
@05nelsonm