Set a more restrictive default umask #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Debian uses a umask of 022, which results in newly created files being world readable. That's not desired for our use case, as we want to restrict access of different users, especially the lobby bots, as much as possible. Therefore, this changes the default umask from 022 to 077 to ensure only the creator of a file can access it by default. When updating an existing lobby server, the file permissions for already existing lobby bots have to be updated manually to make use of the more restrictive permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Debian uses a umask of 022, which results in newly created files being world readable. That's not desired for our use case, as we want to restrict access of different users, especially the lobby bots, as much as possible. Therefore, this changes the default umask from 022 to 077 to ensure only the creator of a file can access it by default.
When updating an existing lobby server, the file permissions for already existing lobby bots have to be updated manually to make use of the more restrictive permissions.