Add information about lowest quality order and hardware acceleration …

…availability to UI
0x90d · Sep 20, 2023 · 76628f3 · 76628f3
1 parent b358888
commit 76628f3
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 3 deletions.
diff --git a/VDF.GUI/ViewModels/MainWindowVM.cs b/VDF.GUI/ViewModels/MainWindowVM.cs
@@ -357,14 +357,16 @@ void BuildDuplicatesView() {
 
 
 
-		public static ReactiveCommand<Unit, Unit> LatestReleaseCommand => ReactiveCommand.Create(() => {
+		public static ReactiveCommand<Unit, Unit> LatestReleaseCommand => ReactiveCommand.CreateFromTask(async  () => {
 			try {
 				Process.Start(new ProcessStartInfo {
 					FileName = "https://github.com/0x90d/videoduplicatefinder/releases",
 					UseShellExecute = true
 				});
 			}
-			catch { }
+			catch {
+				await MessageBoxService.Show("Failed to open URL: https://github.com/0x90d/videoduplicatefinder/releases");
+			}
 		});
 		public static ReactiveCommand<Unit, Unit> OpenOwnFolderCommand => ReactiveCommand.Create(() => {
 			Process.Start(new ProcessStartInfo {

diff --git a/VDF.GUI/ViewModels/MainWindowVM_Settings.cs b/VDF.GUI/ViewModels/MainWindowVM_Settings.cs
@@ -14,6 +14,7 @@
 // */
 //
 
+using System.Diagnostics;
 using System.Linq;
 using System.Reactive;
 using System.Reflection;
@@ -58,6 +59,17 @@ void Instance_LogItemAdded(string message) =>
 				LogItems.Add(message);
 			});
 
+		public ReactiveCommand<Unit, Unit> OpenHWInfoLinkCommand => ReactiveCommand.CreateFromTask(async () => {
+			try {
+				Process.Start(new ProcessStartInfo {
+					FileName = "https://trac.ffmpeg.org/wiki/HWAccelIntro#PlatformAPIAvailability",
+					UseShellExecute = true
+				});
+			}
+			catch {
+				await MessageBoxService.Show("Failed to open URL: https://trac.ffmpeg.org/wiki/HWAccelIntro#PlatformAPIAvailability");
+			}
+		});
 		public ReactiveCommand<Unit, Unit> AddIncludesToListCommand => ReactiveCommand.CreateFromTask(async () => {
 			var result = await Utils.PickerDialogUtils.OpenDialogPicker(
 				new FolderPickerOpenOptions() {

diff --git a/VDF.GUI/Views/MainWindow.xaml b/VDF.GUI/Views/MainWindow.xaml
@@ -31,6 +31,23 @@
         <mvvm:IsBestConverter x:Key="IsBestConverter" />
         <mvvm:ExtraShortDateTimeConverter x:Key="ExtraShortDateTimeConverter" />
     </Window.Resources>
+    <Window.Styles>
+        <Style Selector="Button.hyperlink">
+            <Setter Property="Template">
+                <ControlTemplate>
+                    <TextBlock Text="{TemplateBinding Content}" Foreground="{StaticResource SystemAccentColor}" TextDecorations="Underline">
+                        <TextBlock.Styles>
+                            <Style Selector="TextBlock:pointerover">
+                                <Setter Property="Foreground" Value="{StaticResource SystemAccentColorLight1}"/>
+                            </Style>
+                        </TextBlock.Styles>
+                    </TextBlock>
+                </ControlTemplate>
+            </Setter>
+            <Setter Property="Background" Value="Transparent"/>
+            <Setter Property="BorderThickness" Value="0"/>
+        </Style>
+    </Window.Styles>
     <Border BorderBrush="{DynamicResource SystemControlBackgroundChromeMediumBrush}" BorderThickness="2">
         <Grid>
             <controls:ExperimentalAcrylicBorder
@@ -377,7 +394,7 @@
                                                 <TextBlock
                                                     VerticalAlignment="Center"
                                                     Text="Select Lowest Duration / Quality"
-                                                    ToolTip.Tip="Keep longest / Best Quality" />
+                                                    ToolTip.Tip="Keep longest / Best Quality. The order is: Duration, Resolution, FPS, Bitrate, Audio Bitrate" />
                                             </MenuItem.Header>
                                         </MenuItem>
                                         <MenuItem Header="Date">
@@ -1463,10 +1480,16 @@
                                                         VerticalAlignment="Center"
                                                         Text="{Binding Source={x:Static Settings:SettingsFile.Instance}, Path=CustomFFArguments}"
                                                         ToolTip.Tip="FF(mpeg/probe) arguments passed to the end of the internal arguments. Most users can leave this empty." />
+                                                    <StackPanel Orientation="Horizontal">
                                                     <TextBlock
                                                         VerticalAlignment="Center"
                                                         FontSize="14"
                                                         Text="Hardware Acceleration:" />
+                                                        <Button Command="{Binding OpenHWInfoLinkCommand}"
+                                                                Margin="10,0,0,0"
+                                                                Classes="hyperlink"
+                                                                Content="More Info"/>
+                                                    </StackPanel>
                                                     <ComboBox
                                                         x:Name="ComboboxHardwareAccelerationMode"
                                                         VerticalAlignment="Center"