Update ImageSharp to 3.1.4 (Fixes #516) #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd0f295.
|
Thanks for the PR. Can you try and update it to the latest ImageSharp which is already 3.x and see if that works too? If we bump the version, I prefer the latest if possible. |
|
To my surprise it actually works perfectly with 3.1.4, which should be the latest as of right now. I tested with a fresh dataset and it included them and generated thumbnails perfectly. Tell me if you want me to squash the commits. |
kattjevfel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cd0f295.
From my testing over the last 2 years of reverting this commit, everything works perfect with it, and it allows for webp's to be scanned properly.