fix: reuse audio context #3379

KaustubhKumar05 · 2024-11-19T10:20:35Z

Description

https://app.devrev.ai/100ms/works/ISS-30684

Use existing audio context in plugins manager

Pre-launch Checklist

I updated/added relevant documentation.
The Documentation is updated accordingly, or this PR doesn't require it.
All existing and new tests are passing.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making, or this PR is test-exempt.

Merging:

Squash merge to dev
Merge commit to publish-alpha and main

vercel · 2024-11-19T10:20:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 1:20pm
storybook-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 1:20pm

packages/hms-video-store/src/utils/media.ts

packages/hms-video-store/src/audio-sink-manager/AudioSinkManager.ts

packages/hms-video-store/src/utils/media.ts

KaustubhKumar05 added 2 commits November 19, 2024 15:46

fix: use existing audio context

e147fd9

fix: catch audio plugin errors

ad59352

KaustubhKumar05 changed the title ~~Fix/iss 30684 reuse audio context~~ fix: reuse audio context Nov 19, 2024

vercel bot had a problem deploying to Preview – storybook-app November 19, 2024 10:20 Failure

vercel bot had a problem deploying to Preview – dashboard-app November 19, 2024 10:21 Failure

fix: types

b14386a

vercel bot deployed to Preview – dashboard-app November 19, 2024 10:40 View deployment

vercel bot deployed to Preview – storybook-app November 19, 2024 10:41 View deployment

KaustubhKumar05 requested review from raviteja83 and ygit November 19, 2024 10:45

fix: re-add comment

c580c14

vercel bot deployed to Preview – dashboard-app November 19, 2024 10:48 View deployment

vercel bot deployed to Preview – storybook-app November 19, 2024 10:49 View deployment

raviteja83 reviewed Nov 19, 2024

View reviewed changes

packages/hms-video-store/src/utils/media.ts Outdated Show resolved Hide resolved

raviteja83 reviewed Nov 19, 2024

View reviewed changes

packages/hms-video-store/src/utils/media.ts Outdated Show resolved Hide resolved

fix: resume context in unblockautoplay

34e1c4e

vercel bot deployed to Preview – dashboard-app November 19, 2024 11:07 View deployment

KaustubhKumar05 requested a review from raviteja83 November 19, 2024 11:07

vercel bot deployed to Preview – storybook-app November 19, 2024 11:08 View deployment

raviteja83 reviewed Nov 19, 2024

View reviewed changes

packages/hms-video-store/src/audio-sink-manager/AudioSinkManager.ts Outdated Show resolved Hide resolved

fix: await async methods

c920284

vercel bot deployed to Preview – dashboard-app November 19, 2024 11:15 View deployment

KaustubhKumar05 requested a review from raviteja83 November 19, 2024 11:15

vercel bot deployed to Preview – storybook-app November 19, 2024 11:16 View deployment

raviteja83 reviewed Nov 19, 2024

View reviewed changes

packages/hms-video-store/src/utils/media.ts Outdated Show resolved Hide resolved

fix: create new context if sample rate differs

7fa8f2b

vercel bot deployed to Preview – dashboard-app November 19, 2024 12:08 View deployment

vercel bot deployed to Preview – storybook-app November 19, 2024 12:09 View deployment

fix: missing awaits

70ca28e

vercel bot deployed to Preview – dashboard-app November 19, 2024 13:19 View deployment

vercel bot deployed to Preview – storybook-app November 19, 2024 13:20 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: reuse audio context #3379

fix: reuse audio context #3379

KaustubhKumar05 commented Nov 19, 2024 •

edited

Loading

vercel bot commented Nov 19, 2024 •

edited

Loading

fix: reuse audio context #3379

Are you sure you want to change the base?

fix: reuse audio context #3379

Conversation

KaustubhKumar05 commented Nov 19, 2024 • edited Loading

Description

Pre-launch Checklist

Merging:

vercel bot commented Nov 19, 2024 • edited Loading

KaustubhKumar05 commented Nov 19, 2024 •

edited

Loading

vercel bot commented Nov 19, 2024 •

edited

Loading