Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update hms noise cancellation #3403

Closed
wants to merge 10 commits into from

Conversation

hdz-666
Copy link
Collaborator

@hdz-666 hdz-666 commented Dec 6, 2024

Description

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.


Implementation note, gotchas, related work and Future TODOs (optional)

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Merging:

  • Squash merge to dev
  • Merge commit to publish-alpha and main

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:37am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:37am

@ygit
Copy link
Member

ygit commented Dec 9, 2024

@hdz-666 is this PR to be closed now that we are reverting the NC changes?

@ygit ygit closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants