fix: audio playback error #3419
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygit
requested review from
raviteja83,
KaustubhKumar05,
hdz-666 and
monkCommits
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # packages/hms-video-store/src/audio-sink-manager/AudioSinkManager.ts
| } | ||
| } | ||
|
|
||
| init(elementId?: string) { | ||
| if (this.state.initialized || this.audioSink) { | ||
| HMSLogger.e(this.TAG, 'Audio sink already initialized'); |
There was a problem hiding this comment.
Let's change this to debug instead of error?
| const audioSink = document.createElement('div'); | ||
| audioSink.id = `HMS-SDK-audio-sink-${uuid()}`; | ||
| const userElement = elementId && document.getElementById(elementId); | ||
| const audioSinkParent = userElement || document.body; | ||
| audioSinkParent.append(audioSink); | ||
|
|
||
| this.audioSink = audioSink; | ||
| HMSLogger.d(this.TAG, 'audio sink created', this.audioSink); | ||
| this.state.initialized = true; | ||
| HMSLogger.e(this.TAG, 'audio sink created', this.audioSink); |
There was a problem hiding this comment.
This can also be a debug log
| return; | ||
| } else { | ||
| HMSLogger.e(this.TAG, 'Autoplay succeeded', `${track}`); |
There was a problem hiding this comment.
This can be removed
|
@KaustubhKumar05 Bumping all logs to the error level is intentional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-launch Checklist
Merging: