Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Host/Domain change support added for local avatar url" #247

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

faisal-alvi
Copy link
Member

Reverts #216

After the internal discussion, we are reverting #216 to fix the issues generated after that PR.

Closes #245, Closes #246

How to test the Change

  • Test the issues and see if those are resolved.

Changelog Entry

Fixed - Reverting the Host/Doman support for local avatar URL after seeing new regressions

Credits

Props @jakekackson1 @leogermani @dkotter @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@faisal-alvi faisal-alvi added the type:bug Something isn’t working. label Dec 7, 2023
@faisal-alvi faisal-alvi added this to the 2.7.7 milestone Dec 7, 2023
@faisal-alvi faisal-alvi self-assigned this Dec 7, 2023
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

@faisal-alvi thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@faisal-alvi faisal-alvi requested a review from dkotter December 7, 2023 11:53
@faisal-alvi faisal-alvi merged commit def148d into develop Dec 8, 2023
10 of 12 checks passed
@faisal-alvi faisal-alvi deleted the revert-216-fix/64 branch December 8, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires feedback to determine next steps. type:bug Something isn’t working.
Projects
None yet
2 participants