Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up NPM dependencies and update node to v20 #257

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Clean up NPM dependencies and update node to v20 #257

merged 2 commits into from
Feb 5, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jan 30, 2024 •
edited
Loading

Description of the Change

This PR cleans up NPM dependencies and updates the node version to 20.11.0

Closes #256

Changelog Entry

Changed - Clean up NPM dependencies and update node to v20

Credits

Props @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the 2.8.0 milestone Jan 30, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires feedback to determine next steps. labels Jan 30, 2024
dkotter
dkotter reviewed Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's composer.lock changes here but not seeing any composer.json changes. Was this just a composer update that was run?

@Sidsector9 Sidsector9 requested a review from dkotter February 5, 2024 02:55
@Sidsector9 Sidsector9 merged commit ebf18d9 into develop Feb 5, 2024
11 checks passed
@Sidsector9 Sidsector9 deleted the upkeep/node branch February 5, 2024 15:01
@faisal-alvi faisal-alvi modified the milestones: 2.8.0, 2.7.8 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

Assignees

@Sidsector9 Sidsector9

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
2.7.8
Development

Successfully merging this pull request may close these issues.

Clean up NPM dependencies and update node to v20
3 participants
@Sidsector9 @dkotter @faisal-alvi