Fix/231 Broken default avatar when Local Avatars Only is unchecked

[faisal-alvi]

Description of the Change

When the 'Local Avatars Only' setting is unchecked (i.e., disabled), the 'Default Avatar' setting was not being applied. Consequently, the gravatar was returned for images when no original image was set, resulting in broken avatars for users whose gravatar was not set.

This PR addresses this issue by displaying the 'Default Avatar' even when the 'Local Avatars Only' setting is disabled.

before

after

Closes #231

How to test the Change

1. Go to the avatar settings /wp-admin/options-discussion.php.
2. Choose the option to upload a custom image as your avatar.
3. Upload a custom image.
4. Make sure to untick the Local Avatars Only option.
5. Save the changes.
6. View the user's profile or avatar in various parts of the system.
7. There should not be any broken avatar images and the default avatar image should be shown as a fallback image.

Changelog Entry

Fixed - Broken default avatar when ' Local Avatars Only` is unchecked.

Credits

Props @ankitguptaindia @faisal-alvi

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[qasumitbagthariya]

QA Update ✅

---

@faisal-alvi Thanks for the PR

I have verified that the associated problem in the fix/231 branch has been fixed and is functioning as intended.

Video:
https://drive.google.com/file/d/15pPXeAFS4faECYrzh-7d8yN3DkQ0nWfk/view?usp=sharing

Testing Environment

• WordPress: 6.4.3
• Theme: Twenty Twenty-FourVersion: 1.0
• PHP: 8.0.30
• Web Server: Nginx 1.20.2
• Browser: Chrome
• OS: macOS Ventura 13.3