Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - #224 Avoid php warnings #261

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix - #224 Avoid php warnings #261

merged 3 commits into from
Mar 12, 2024

Conversation

BhargavBhandari90
Copy link
Contributor

Description of the Change

Add checks to avoid PHP warnings.

Closes #224

How to test the Change

  • I was not able to replicate the warning. But it is good to add checks, especially for the array for php8.

Changelog Entry

Fixed - Possible PHP warning

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.8.0 milestone Mar 11, 2024
@BhargavBhandari90 @dkotter
Remove unnecessary check
31319ab 
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
@jeffpaul jeffpaul requested review from dkotter and removed request for jeffpaul March 11, 2024 21:31
@dkotter dkotter merged commit 3089823 into 10up:develop Mar 12, 2024
11 checks passed
@faisal-alvi faisal-alvi modified the milestones: 2.8.0, 2.7.8 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@BhargavBhandari90 BhargavBhandari90

Labels
None yet
Projects
None yet
Milestone
2.7.8
Development

Successfully merging this pull request may close these issues.

PHP warnings due to wrong param type
4 participants
@BhargavBhandari90 @dkotter @jeffpaul @faisal-alvi