Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-13006: remove all instances of skip_doc_auth and skipDocAuth - step 4.5 of 6 #11455

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

LG-13006: remove all instances of skip_doc_auth and skipDocAuth - step 4.5 of 6 #11455

wants to merge 4 commits into from

Conversation

KeithNava
Copy link
Contributor

@KeithNava KeithNava commented Nov 5, 2024 •
edited
Loading

🎫 Ticket

Link to the relevant ticket:
LG-13006

🛠 Summary of changes

This is one of the last steps a part of the parent ticket LG-13006 to remove the old skip_doc_auth variable after the new
renamed variable of skip_doc_auth_from_how_to_verify was introduced

@KeithNava KeithNava force-pushed the keithw/LG-13006-rename-skip-doc-auth-value-step-4-removal branch from f371201 to b56eadc Compare November 5, 2024 19:57
@KeithNava KeithNava requested review from a team and gina-yamada November 6, 2024 13:41
@KeithNava KeithNava marked this pull request as ready for review November 6, 2024 13:41
shanechesnutt-ft
shanechesnutt-ft reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go so far. I noticed that the app/services/idv/session.rb and app/controllers/idv/socure/document_capture_controller.rb still have skip_doc_auth items have you looked at those? I wasn't sure if you meant to leave those in or not.

@KeithNava KeithNava force-pushed the keithw/LG-13006-rename-skip-doc-auth-value-step-4-removal branch from b56eadc to 336a20c Compare November 12, 2024 15:10
@KeithNava KeithNava requested a review from a team November 12, 2024 15:11
jennyverdeyen
jennyverdeyen reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@jennyverdeyen jennyverdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me - I just see one remaining instance of skip_doc_auth in app/services/idv/session.rb still, unless that is intentional!

@KeithNava
Copy link
Contributor Author

@shanechesnutt-ft @jennyverdeyen thanks for the callouts, we actually have the removal of the variable from the session.rb as the next after the deployment in the ticket 👉 https://cm-jira.usa.gov/browse/LG-13006

shanechesnutt-ft
shanechesnutt-ft approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyverdeyen jennyverdeyen jennyverdeyen left review comments

@shanechesnutt-ft shanechesnutt-ft shanechesnutt-ft approved these changes

@gina-yamada gina-yamada Awaiting requested review from gina-yamada gina-yamada was automatically assigned from 18F/identity-joy-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeithNava @jennyverdeyen @shanechesnutt-ft