Add rubocop-disable_syntax #11513
Draft
Add rubocop-disable_syntax #11513
+577
−1,700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.rubocop.yml
Outdated
|
|
||
| Style/DisableSyntax: | ||
| DisableSyntax: | ||
| - unless |
There was a problem hiding this comment.
I don't actually mind unless, but I don't oppose this change either.
I was warned at a previous job that "people will hurt you" when I wrote an unless... else though. 😉 (unless !something is also cruel.)
There was a problem hiding this comment.
(The size of this PR seems to argue that it's well-entrenched and should maybe stay too?)
Comment on lines
-230
to
+234
| Description: Limit lines to 100 characters. | ||
| Description: Limit lines to 120 characters. | ||
| StyleGuide: https://github.com/bbatsov/ruby-style-guide#80-character-limits | ||
| Enabled: true | ||
| Max: 100 | ||
| Max: 120 |
There was a problem hiding this comment.
I am happy enough with 100. But I wanted to point out we do have our JS files with a matching 100, if we change this I think we should change them together to keep the whole codebase consistent
Line 4 in 74f0ff0
changelog: Internal, Maintenance, Change Rubocop rules
mitchellhenke
force-pushed
the
mitchellhenke/rubocop-bold
branch
from
0ccae77
to
e49f4a1
Compare
mitchellhenke
force-pushed
the
mitchellhenke/rubocop-bold
branch
from
e49f4a1
to
1b26c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This is a proof-of-concept intended to start discussion about changing some of our Rubocop rules