Refactor/remove multi faceted abstraction smell #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of DirectoryScanner class into FileProcessor, FileTypeDetector and DirectorScanner class
…of DirectoryScanner class into FileProcessor, FileTypeDetector and DirectorScanner class. Also performed Conditional Polymorphism to make it possible to add new FileProcessors in future
|
There is currently no plan for adding new file formats, so an extensible file processing logic is not needed. What is the use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I tried to solve multi-faceted abstraction smell present in the DirectoryScanner class. This class was performing multiple tasks, so I have extracted them into separate classes with there being an abstraction for processing file such that new ways of processing file can be added easily in future by extending FileProcessor class and adding logic for the new processing function.
I built the program using command gradle installDist, and it built completely without any issues and I was able to run the GUI without any errors.
If you need any further explanation before merging the PR, please let me know.