Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Soft-Deprecate system-sphinx from System API #265

Merged
merged 9 commits into from
Jul 3, 2023

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented Jul 3, 2023

System is already using now system-searchd instead of system-sphinx.

So system-sphinx has been soft-deprecated:

  • Searchd statefulset is enabled by default
  • Searchd is the default searchAdress (it still permits use an external sphinx)
  • As sphinx spec is still used on deployed System CRs ( spec.sphinx.config.enabled: false), it has not been removed 100% (just left this specific CR fields available although its controllers have already been removed)
  • Sphinx will be completely removed on a follow-up PR once all deployed CRs has been updated by removing the field spec.sphinx.config.enabled: false

In addition, a few typos have been fixed on different generators, including system-sphinx label on system-console statefulset, forcing a rollout.

An alpha release has been tested successfully in staging, desired consequences:

  • system-sphinx service removed
  • system-console statefulset rollout because of previous incorrect sphinx label

/kind cleanup
/kind release
/priority important-soon
/assign

@3scale-robot 3scale-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 3, 2023
@3scale-robot 3scale-robot added the kind/release Categorizes issue or PR as related to a new release. label Jul 3, 2023
@3scale-robot 3scale-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jul 3, 2023
@raelga
Copy link
Contributor

raelga commented Jul 3, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f67b3cb3b8baeabe9aed355b0c4d599a3de3df16

@slopezz
Copy link
Member Author

slopezz commented Jul 3, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@3scale-robot 3scale-robot merged commit f8d510a into main Jul 3, 2023
@3scale-robot 3scale-robot deleted the feat/deprecate-system-sphinx branch July 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/release Categorizes issue or PR as related to a new release. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/L Requires few days to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants