-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Soft-Deprecate system-sphinx from System API #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
the
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
label
Jul 3, 2023
3scale-robot
added
the
kind/release
Categorizes issue or PR as related to a new release.
label
Jul 3, 2023
3scale-robot
added
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
size/L
Requires few days to complete the PR or the issue.
and removed
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
labels
Jul 3, 2023
/lgtm |
LGTM label has been added. Git tree hash: f67b3cb3b8baeabe9aed355b0c4d599a3de3df16
|
roivaz
approved these changes
Jul 3, 2023
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/release
Categorizes issue or PR as related to a new release.
lgtm
Indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
size/L
Requires few days to complete the PR or the issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System is already using now system-searchd instead of system-sphinx.
So system-sphinx has been soft-deprecated:
spec.sphinx.config.enabled: false
), it has not been removed 100% (just left this specific CR fields available although its controllers have already been removed)spec.sphinx.config.enabled: false
In addition, a few typos have been fixed on different generators, including
system-sphinx
label onsystem-console
statefulset, forcing a rollout.An alpha release has been tested successfully in staging, desired consequences:
/kind cleanup
/kind release
/priority important-soon
/assign