Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag s3 redis backup objects with more info #272

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Tag s3 redis backup objects with more info #272

merged 1 commit into from
Oct 11, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 10, 2023

Adds more tags to s3 backup object so the origin server can be identified

/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 10, 2023
@3scale-robot 3scale-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XS Requires less than an hour to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 10, 2023
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 136ff98d42bfe6691047e000a3d790c65faf6930

@roivaz
Copy link
Member Author

roivaz commented Oct 11, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/contains-merge-commits and removed lgtm Indicates that a PR is ready to be merged. labels Oct 11, 2023
@roivaz roivaz added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@3scale-robot 3scale-robot merged commit 8904936 into main Oct 11, 2023
3 checks passed
@3scale-robot 3scale-robot deleted the backups-moar-tags branch October 11, 2023 09:53
@roivaz
Copy link
Member Author

roivaz commented Nov 3, 2023

Related to https://github.com/3scale/platform/issues/868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga Awaiting requested review from raelga

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/XS Requires less than an hour to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roivaz @3scale-robot @raelga @slopezz