Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to basereconciler v0.3.4 #275

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 16, 2023

Fixes a bug in the basreconciler. See 3scale-ops/basereconciler#6.

/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 16, 2023
@3scale-robot 3scale-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XS Requires less than an hour to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 16, 2023
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2f2f8d4d35a0d55b1c7688cee6b81d6a41c18ad2

@roivaz
Copy link
Member Author

roivaz commented Oct 16, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@3scale-robot 3scale-robot merged commit 1466ba2 into main Oct 16, 2023
5 checks passed
@3scale-robot 3scale-robot deleted the basereconciler-v0.3.4 branch October 16, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/XS Requires less than an hour to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants