Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track action on GenericModelView #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Track action on GenericModelView #167

wants to merge 1 commit into from

Conversation

taion
Copy link
Contributor

@taion taion commented Feb 2, 2018

It's occasionally convenient to track the semantic action. This seems pretty straightforward as an implementation.

itajaja
itajaja reviewed Feb 2, 2018
View reviewed changes
Copy link
Member

@itajaja itajaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels really brittle. what's the rationale? have you thought about putting this in the request context (not that it makes it any less brittle, conceptually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itajaja itajaja itajaja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @itajaja