feat: Add an upsert_item method #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is the right way to go. I think we might want more of a |
itajaja
reviewed
Mar 26, 2020
| item = self.update_item(item, data_in) or item | ||
| self.commit() | ||
| item = self.upsert_item(item, data_in) or item | ||
| updated = inspect(item).persistent |
There was a problem hiding this comment.
this might not work if for some reason someone changes how the creation and upsert method work. what about upsert_item returns a tuple (item: T, created: bool)?
There was a problem hiding this comment.
I know. Awkward either way. It's why I'd be more inclined to add a new hook.
itajaja
reviewed
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.