Merge pull request OpenRCT2#21389 from ZehMatt/error-update-1

Don't close the error window if the new error will not show

src/openrct2-ui/windows/Error.cpp

@@ -111,8 +111,6 @@ class ErrorWindow final : public Window
 
 WindowBase* WindowErrorOpen(std::string_view title, std::string_view message)
 {
-    WindowCloseByClass(WindowClass::Error);
-
     std::string buffer = "{BLACK}";
     buffer.append(title);
 
@@ -137,6 +135,9 @@ WindowBase* WindowErrorOpen(std::string_view title, std::string_view message)
         return nullptr;
     }
 
+    // Close any existing error windows if they exist.
+    WindowCloseByClass(WindowClass::Error);
+
     int32_t width = GfxGetStringWidthNewLined(buffer.data(), FontStyle::Medium);
     width = std::clamp(width, 64, 196);