refactor: remove unneeded check (#3394)

99designs · Nov 25, 2024 · b110c1d · b110c1d
1 parent 4310a7f
commit b110c1d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -12,6 +12,12 @@ linters-settings:
       - paramTypeCombine
       - preferFprint
       - yodaStyleExpr
+  govet:
+    enable-all: true
+    disable:
+      - fieldalignment
+      - shadow
+      - unusedwrite # TODO: fix and enable
   errcheck:
     exclude-functions:
       - (io.Writer).Write

diff --git a/plugin/modelgen/models.go b/plugin/modelgen/models.go
@@ -356,7 +356,6 @@ func (m *Plugin) generateField(
 	schemaType *ast.Definition,
 	field *ast.FieldDefinition,
 ) (*Field, error) {
-	var omittableType types.Type
 	var typ types.Type
 	fieldDef := cfg.Schema.Types[field.Type.Name()]
 
@@ -449,13 +448,9 @@ func (m *Plugin) generateField(
 			return nil, fmt.Errorf("generror: field %v.%v: omittable is only applicable to nullable input fields", schemaType.Name, field.Name)
 		}
 
-		var err error
-
-		if omittableType == nil {
-			omittableType, err = binder.FindTypeFromName("github.com/99designs/gqlgen/graphql.Omittable")
-			if err != nil {
-				return nil, err
-			}
+		omittableType, err := binder.FindTypeFromName("github.com/99designs/gqlgen/graphql.Omittable")
+		if err != nil {
+			return nil, err
 		}
 
 		f.Type, err = binder.InstantiateType(omittableType, []types.Type{f.Type})